fix: warn and skip linking when a t-frame has no segments (#274)#276
Merged
Conversation
compute_spatial_neighbors crashed with IndexError: tuple index out of range when either source or target nodes were empty, because np.asarray([]) returns a 1D array of shape (0,) and target_pos.shape[1] is then undefined. Guard both sides and emit a RuntimeWarning identifying which side (source or target) and which t-frame is empty, so users running long timelapses can pinpoint the offending frame instead of hitting an opaque error inside multiprocessing.pool. Adds a parametrized regression test covering empty source, empty target, and both-empty cases. Closes #274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #274. Supersedes #275 (branch deleted).
compute_spatial_neighborscrashed withIndexError: tuple index out of rangewhen any t-frame had zero detected cells, becausenp.asarray([]).shape[1]is undefined.Guard both source and target and emit a
RuntimeWarningidentifying which side and which t-frame is empty, then skip linking for that pair — so users running long timelapses can pinpoint the offending frame instead of hitting an opaque error insidemultiprocessing.pool.Adds a parametrized regression test covering empty source, empty target, and both-empty cases.